Fix integer overflow in _checkCount(minimum:) - #60
Merged
Conversation
The current implementation adds the given `minimum` and `_lowerBound`, which can wrap around if the minimum is very large, incorrectly passing the size check. This change uses `count` instead, which is always the real upper bound for `minimum`.
natecook1000
force-pushed
the
fix/checkcount-overflow
branch
from
August 17, 2026 21:37
b51c640 to
3224cd4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current implementation adds the given
minimumand_lowerBound, which can wrap around if the minimum is very large, incorrectly passing the size check. This change usescountinstead, which is always the real upper bound forminimum.Checklist
Scripts/format.shto correctly format my change